When flyweight.py is run as skript it raises an error

[fkromer]

When flyweight.py is run as skript the following output is generated:

<Card: 9h> <Card: 9h>
True True
50022776 50022776
True
False
Traceback (most recent call last):
  File "D:\Users\Florian\Documents\GitHub\python-patterns\flyweight.py", line 92, in <module>
    instances_pool = getattr(Card2, 'pool')
AttributeError: type object 'Card2' has no attribute 'pool'

[faif]

I confirm that it fails in Python 3. Any idea about the source of the problem?

[fkromer]

Not yet. I decided to write the unit tests for the other patterns first.

[ar4s]

First of all, Python 3 ignores __metaclass__ attribute, use class Foo(metaclass=BarMeta) for Python 3 or use six library (https://pythonhosted.org/six/#six.with_metaclass) for cross-version compatibility. Secondly, in Py 3.x map returns genarator instead of list.

[faif]

@ar4s Thanks for the tips. Feel free to fix it if you feel like :)

[yarikoptic]

For now I have just "disabled" it in 393a81f which is a part of #144 to straighten all the testing

[duboviy]

I've added following pull request:
#161

@faif could you please have a quick look on this issue?

[faif]

Although I would prefer to avoid the extra module (six) dependency, it is a solution so thanks @duboviy 👍

[duboviy]

Fully agree with @faif that in current project it would be much better to not depend on third party packages.

So if you @faif would like, I'll create a pull request with removing six dependency and using some kind of workaround like this function instead of using six module:

def with_metaclass(meta, *bases):
    class metaclass(meta):
        def __new__(cls, name, this_bases, d):
            return meta(name, bases, d)
    return type.__new__(metaclass, 'temporary_class', (), {})

...

class Card2(with_metaclass(FlyweightMeta, object)):

...

[faif]

@duboviy Sure, go ahead

[duboviy]

I've added following pull request:
#162

@faif, I'm very sorry to disturb you
please, kindly ask you to review this change ;)

[faif]

@duboviy Thanks. No need to apologise for your useful contributions 👍