Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implementation for the GET Offers by userId endpoint #23

Merged
merged 54 commits into from
Jul 14, 2020
Merged

Implementation for the GET Offers by userId endpoint #23

merged 54 commits into from
Jul 14, 2020

Conversation

kat-ka
Copy link
Contributor

@kat-ka kat-ka commented Jul 7, 2020 •
edited
Loading

Returns

  • 200 with an Offer Page in the response body when the request parameter value userId is not empty
  • 400 for missing or empty userId and an error message in the response body

Uses Pageable for managing the result list by page, size and sort. Default values are

  • 0 for page
  • 10 for size with maximum limit 1000
  • sort by startDate and startTime

Test cases are included.

There are also some Gradle build management updates and some more details in the deployment description file.

Fixes issues found in the Swagger editor online tool concerning api-doc's component security schemes.

kat-ka added 24 commits July 7, 2020 12:03
@kat-ka
pageable configuration
23b51c8
@kat-ka
update exception handling for get offers by userId
4350fc8
@kat-ka
get offers by id functionality
9a61fd1
@kat-ka
unused import
9f1c5b4
@kat-ka
update Swagger documentation
fa1829f
@kat-ka
cleanup
0966d0f
@kat-ka
change converter to bean
2b3a8aa
@kat-ka
new method for API Offer instance to JSON String
01d6133
@kat-ka
REST API request logging
223c2a3
@kat-ka
auto sort imports
05cd6c0
@kat-ka
Spring Boot property name changed from version 1.x to 2.x
eadf461
@kat-ka
Spring Boot property name changed from version 1.x to 2.x
5ffe0d4
@kat-ka
sort and add comments
11cde81
@kat-ka
use REST API root path
96ab983
@kat-ka
default
a48805b
@kat-ka
correction
31acad9
@kat-ka
logging options
8faf340
@kat-ka
use Spring Boot's property name instead of custom one
ba3b79f
@kat-ka
naming convention
69e359b
@kat-ka
unused import
6b3057b
@kat-ka
naming convention
d2b73b1
@kat-ka
update and add tests
8c95d3a
@kat-ka
format
5534971
@kat-ka
format
b9f5ae1
@kat-ka kat-ka linked an issue Jul 7, 2020 that may be closed by this pull request
Functionality for the GET Offers endpoint #21
Closed
@kat-ka kat-ka requested a review from yncyrydybyl July 7, 2020 15:43
kat-ka added 24 commits July 9, 2020 09:20
@kat-ka
update H2 console access
2bba0a4
@kat-ka
not needed, already in dependencies
4133dc9
@kat-ka
default value is sourceCompatibility
9c531fa
@kat-ka
more common
532ea76
@kat-ka
included in Spring Boot
d150d71
@kat-ka
update version
1372981
@kat-ka
included in 'spring-data-jpa'
4c02a6d
@kat-ka
included in 'spring-boot-starter-actuator'
03bac10
@kat-ka
java plugin defaults
cec8148
@kat-ka
use new version for library changes
02c6155
@kat-ka
use repository content filter
d8852c6
@kat-ka
make sure, env. variables overwrite local properties
bc0833b
@kat-ka
nexus as in-house maven repository
c248425
@kat-ka
Actuator configuration
1a75598
@kat-ka
Actuator without authorization
b7acdb7
@kat-ka
Actuator URIs
2781355
@kat-ka
short intro
8317032
@kat-ka
deployment description and small changes
9af06d8
@kat-ka
use as needed
ec3d3a5
@kat-ka
format
9fc24f5
@kat-ka
change it back
c2a7a5e
@kat-ka
the swagger editor online tool complains about the space character
2352349
@kat-ka
the swagger editor online tool complains about additional properties …
da8e97f 
…'name' and 'in' at it's components security schemes
@kat-ka
change it back
5ffa359
@kat-ka kat-ka merged commit cf32de2 into master Jul 14, 2020
@kat-ka kat-ka deleted the issue-21 branch July 14, 2020 07:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yncyrydybyl yncyrydybyl yncyrydybyl approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Functionality for the GET Offers endpoint
2 participants
@kat-ka @yncyrydybyl