Make criterion a benchmarking only dependency #54
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
Author
|
Will merge even if CI does not pass. Because the changes in #53 are also needed. But I want to keep them as separate PRs, since they do completely different things. |
faern
force-pushed
the
hide-criterion-behind-cfg
branch
from
a7e896c to
c0b19d9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Criterion is a pretty big dependency, and it has a higher MSRV than the library itself and the other testing dependencies. To to be able to run
cargo testwithout pulling criterion in, I had to do this hack. It's similar to theloomhack.The major downside is that to run benchmarks one now has to run them with
RUSTFLAGS="--cfg criterion" cargo bench