Skip to content

Consistency - Make builders fluent. #3

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Mar 11, 2021
Merged

Consistency - Make builders fluent. #3

merged 2 commits into from
Mar 11, 2021

Conversation

@drupol
Copy link
Contributor

@drupol drupol commented Mar 11, 2021 •
edited
Loading

This PR:

  • Add consistency
  • Make sure that AbstractServiceBuilder is fluent
  • Make sure that AuthorizationServiceBuilder is fluent

@drupol drupol changed the title Make AbstractServiceBuilder fluent. WIP - Make AbstractServiceBuilder fluent. Mar 11, 2021
@drupol drupol changed the title WIP - Make AbstractServiceBuilder fluent. Consistency - Make builder fluent. Mar 11, 2021
@drupol drupol changed the title Consistency - Make builder fluent. Consistency - Make builders fluent. Mar 11, 2021
@thomasvargiu
Copy link
Member

thomasvargiu commented Mar 11, 2021

I agree, fluent interface is better on builders. Thanks.

@thomasvargiu thomasvargiu merged commit c77b02b into facile-it:master Mar 11, 2021
@drupol
Copy link
Contributor Author

drupol commented Mar 11, 2021

Yes, but that was not the main reason of that PR. Some builders were fluent, some were not... so I fixed that :)

@drupol drupol deleted the make-AbstractServiceBuilder-fluent branch March 11, 2021 21:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@drupol @thomasvargiu