Support authorization endpoint containing query params #26
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Right now, if the well-known url provides an authorization endpoint containing a query, the
AuthorizationServicewill build a wrong url, which will eventually contains the symbol?twice.This PR adds the unit test to spot the case, so adds some checks on the uri generation in order to prevent the problem.
Even better would be to have to separate tests, one for the uri containing params and one for the uri without params, but this is up to you.
I wasn't able to perform a
composer run psalmbefore opening the PR since it looks broken, I am sorry.