Skip to content

Conversation

@antonioeatgoat
Copy link
Contributor

Right now, if the well-known url provides an authorization endpoint containing a query, the AuthorizationService will build a wrong url, which will eventually contains the symbol ? twice.

This PR adds the unit test to spot the case, so adds some checks on the uri generation in order to prevent the problem.
Even better would be to have to separate tests, one for the uri containing params and one for the uri without params, but this is up to you.

I wasn't able to perform a composer run psalm before opening the PR since it looks broken, I am sorry.

@codecov
Copy link

codecov bot commented Feb 20, 2023

Codecov Report

Base: 59.89% // Head: 60.00% // Increases project coverage by +0.10% 🎉

Coverage data is based on head (9b3adca) compared to base (b47e83d).
Patch coverage: 100.00% of modified lines in pull request are covered.

❗ Current head 9b3adca differs from pull request most recent head 69687af. Consider uploading reports for the commit 69687af to get more accurate results

Additional details and impacted files
@@             Coverage Diff              @@
##             master      #26      +/-   ##
============================================
+ Coverage     59.89%   60.00%   +0.10%     
- Complexity      465      466       +1     
============================================
  Files            62       62              
  Lines          1521     1525       +4     
============================================
+ Hits            911      915       +4     
  Misses          610      610              
Impacted Files Coverage Δ
src/Service/AuthorizationService.php 49.56% <100.00%> (+1.81%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Member

@thomasvargiu thomasvargiu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! It's ok, just few changes.

@thomasvargiu thomasvargiu merged commit 08729fd into facile-it:master Feb 21, 2023
@thomasvargiu
Copy link
Member

Thanks @antonioeatgoat! Give me some time to fix psalm issues and I'll release it

@antonioeatgoat
Copy link
Contributor Author

Thank you @thomasvargiu for the very quick feedback!

@thomasvargiu
Copy link
Member

Released in 0.3.3

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants