Skip to content

Conversation

@drupol
Copy link
Contributor

@drupol drupol commented Mar 15, 2021

In order to have a consistency across all the builders,

I propose to:

  • Rename MetadataProviderBuilder::setClient() into MetadataProviderBuilder::setHttpClient()

Copy link
Member

@Jean85 Jean85 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a breaking change. We should mirror the method and deprecate the old name to reduce the need for a major version bump.

@thomasvargiu
Copy link
Member

I have some doubts about changing the http client setters and getters to "client". In our domain there is another entity named "client". @drupol @Jean85 what do you think?

@drupol
Copy link
Contributor Author

drupol commented Mar 16, 2021

I would use setHttpClient for sure to avoid any confusion.

@thomasvargiu
Copy link
Member

Oh sorry, you're right, I read it in the wrong way 👍

@thomasvargiu thomasvargiu merged commit cb462ec into facile-it:master Mar 16, 2021
@drupol drupol deleted the use-gethttpclient-instead-of-getclient branch March 16, 2021 12:19
@drupol
Copy link
Contributor Author

drupol commented Mar 16, 2021

Grazie a voi !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants