fix firefox jsonview, and other updates #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- new firefox versions ship with `jsonview` preference enabled, which turns json into pretty print html and breaks tool; i have fixed this by passing in a firefox profile to webdriver with it disabled - gets rid of `pip` `sudo` warnings - adds required gtk3 libs to `apt-get install` - updated `README` with additional macOS instruction for shared folders - `setup` creates local `.env` file for user now - wait for login form to appear, instead of sleeping for arbitrary number of seconds - indentation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
jsonviewpreference enabled, which turns json into pretty print html and breaks tool; i have fixed this by passing in a firefox profile to webdriver with it disabledpipsudowarningsapt-get installREADMEwith additional macOS instruction for shared folderssetupcreates local.envfile for user now