Skip to content

Commit

Permalink
CSS: WPT tests property values are supported.
Browse files Browse the repository at this point in the history
test_computed_value now checks that the value is supported.

Change-Id: Ic8c38df6030b3689f4fdec30a55f230d6cc113d2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1866498
Reviewed-by: Alison Maher <almaher@microsoft.com>
Commit-Queue: Eric Willigers <ericwilligers@chromium.org>
Auto-Submit: Eric Willigers <ericwilligers@chromium.org>
Cr-Commit-Position: refs/heads/master@{#708034}
  • Loading branch information
ericwilligers authored and Hexcles committed Oct 23, 2019
1 parent f87822f commit 32ffb13
Show file tree
Hide file tree
Showing 4 changed files with 3 additions and 9 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -6,13 +6,6 @@
<script src="/css/support/computed-testcommon.js"></script>
<div id="target"></div>
<script>
test_computed_value("forced-color-adjust", "", "auto");
test_computed_value("forced-color-adjust", "auto");
test_computed_value("forced-color-adjust", "none");
// reserved and css-wide keywords.
test_computed_value("forced-color-adjust", "initial", "auto");
test_computed_value("forced-color-adjust", "inherit", "auto");
test_computed_value("forced-color-adjust", "unset", "auto");
test_computed_value("forced-color-adjust", "revert", "auto");
test_computed_value("forced-color-adjust", "default", "auto");
</script>
Original file line number Diff line number Diff line change
Expand Up @@ -10,4 +10,6 @@
test_invalid_value("forced-color-adjust", "none none");
test_invalid_value("forced-color-adjust", "none auto");
test_invalid_value("forced-color-adjust", "1");
test_invalid_value("forced-color-adjust", "revert");
test_invalid_value("forced-color-adjust", "default");
</script>
Original file line number Diff line number Diff line change
Expand Up @@ -13,8 +13,6 @@
<div id="target"></div>
<script>
test_computed_value("transition-timing-function", "linear");
test_computed_value("transition-timing-function", "", "ease");
test_computed_value("transition-timing-function", "initial", "ease");

test_computed_value("transition-timing-function", "ease");
test_computed_value("transition-timing-function", "ease-in");
Expand Down
1 change: 1 addition & 0 deletions css/support/computed-testcommon.js
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,7 @@ function test_computed_value(property, specified, computed) {
test(() => {
const target = document.getElementById('target');
assert_true(property in getComputedStyle(target), property + " doesn't seem to be supported in the computed style");
assert_true(CSS.supports(property, specified), "'" + specified + "' is a supported value for " + property + ".");
target.style[property] = '';
target.style[property] = specified;

Expand Down

0 comments on commit 32ffb13

Please sign in to comment.