fix: calculates slide width on first pass #15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adiba
reviewed
Apr 20, 2023
| const memoizedSlideWidth = useMemo(() => { | ||
| return `${(slidesToShow > 1 ? 1 / slidesToShow : slidesToShow) * 100}%` | ||
| }, [slidesToShow]); | ||
|
|
There was a problem hiding this comment.
No need to memoize. We can just write const slideWidth = `...`;
There was a problem hiding this comment.
I think we may want to keep the slider widths uninitialized, see my comment here: #17 (comment)
There was a problem hiding this comment.
I don't see the benefit of waiting a render cycle to provide known information via context?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Calculates the slide width outside of the effect, so context has the correct slide width on the first pass.