Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[minor] Adding dev version numbering' #279

Merged
merged 1 commit into from
Apr 21, 2022
Merged

[minor] Adding dev version numbering' #279

merged 1 commit into from
Apr 21, 2022

Conversation

blefaudeux
Copy link
Contributor

What does this PR do?

Discussed on the Triton2 PR, move the python package numbering to 'next.dev' to make it easier to differentiate in between the current main package and the pip version

Before submitting

  • Did you have fun?
    • Make sure you had fun coding 🙃
  • Did you read the contributor guideline?
  • Was this discussed/approved via a Github issue? (no need for typos, doc improvements)
    • N/A
  • Did you make sure to update the docs?
    • N/A
  • Did you write any new necessary tests?
    • N/A
  • Did you update the changelog? (if needed)
    • N/A

PR review

Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.

@blefaudeux blefaudeux requested a review from fmassa April 21, 2022 16:36
@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Apr 21, 2022
@blefaudeux blefaudeux requested a review from dianaml0 April 21, 2022 16:36
@blefaudeux blefaudeux merged commit b9f2111 into main Apr 21, 2022
@blefaudeux blefaudeux deleted the add_dev_numbering branch April 21, 2022 16:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants