Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

release 0.0.9 #215

Merged
merged 2 commits into from
Feb 9, 2022
Merged

release 0.0.9 #215

merged 2 commits into from
Feb 9, 2022

Conversation

dianaml0
Copy link
Contributor

@dianaml0 dianaml0 commented Feb 9, 2022

What does this PR do?

Fixes # (issue).

Before submitting

  • Did you have fun?
    • Make sure you had fun coding 🙃
  • Did you read the contributor guideline?
  • Was this discussed/approved via a Github issue? (no need for typos, doc improvements)
    • N/A
  • Did you make sure to update the docs?
    • N/A
  • Did you write any new necessary tests?
    • N/A
  • Did you update the changelog? (if needed)
    • N/A

PR review

Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Feb 9, 2022
@dianaml0 dianaml0 requested review from blefaudeux and fmassa February 9, 2022 20:00
blefaudeux
blefaudeux approved these changes Feb 9, 2022
View reviewed changes
Copy link
Contributor

@blefaudeux blefaudeux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks great to me, and sorry for not being tighter with the changelog @dianaml0 !

@dianaml0 dianaml0 merged commit 4c888f2 into main Feb 9, 2022
@dianaml0 dianaml0 deleted the release0.0.9 branch February 9, 2022 20:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@blefaudeux blefaudeux blefaudeux approved these changes

@fmassa fmassa Awaiting requested review from fmassa

Assignees
No one assigned
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dianaml0 @blefaudeux @facebook-github-bot