Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[doc][minor] Adding more fused layers data to the HTML docs #174

Merged
merged 1 commit into from
Jan 4, 2022
Merged

[doc][minor] Adding more fused layers data to the HTML docs #174

merged 1 commit into from
Jan 4, 2022

Conversation

blefaudeux
Copy link
Contributor

What does this PR do?

Adds the fused layers benchmarks to the HTML docs, a lot of them were missing or old.

Before submitting

  • Did you have fun?
    • Make sure you had fun coding 🙃
  • Did you read the contributor guideline?
  • Was this discussed/approved via a Github issue? (no need for typos, doc improvements)
    • N/A
  • Did you make sure to update the docs?
    • N/A
  • Did you write any new necessary tests?
    • N/A
  • Did you update the changelog? (if needed)
    • N/A

PR review

Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Jan 4, 2022
@blefaudeux
Copy link
Contributor Author

Now looks like the following

Screenshot from 2022-01-04 15-35-00

  • updated numbers with an Ampere GPU

@blefaudeux blefaudeux changed the title [doc][minor] Adding more data to the HTML docs [doc][minor] Adding more fused layers data to the HTML docs Jan 4, 2022
@blefaudeux
Copy link
Contributor Author

Guessing that this is fine to insta-land, no new code, cc @fmassa @dianaml0 @jieru-hu

@blefaudeux blefaudeux merged commit 3683752 into main Jan 4, 2022
@blefaudeux blefaudeux deleted the docs_fused_layers branch January 4, 2022 23:45
xwhan pushed a commit to xwhan/xformers that referenced this pull request Feb 8, 2022
@blefaudeux
[nit] Pre layer norm style for LRA (facebookresearch#174)
fd3ac19 
results in bash tail_all_results.sh logs/cluster_pre_ln/
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@blefaudeux @facebook-github-bot