[docs] Adding some new content, better credits, missing authors #17
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
blefaudeux
requested review from
Vittorio-Caggiano,
jieru-hu,
dianaml0,
fmassa and
suchenzang
blefaudeux
force-pushed
the
doc_improvements
branch
from
dc53665 to
d8690a5
Compare
blefaudeux
force-pushed
the
doc_improvements
branch
from
3fbff73 to
7814c96
Compare
dianaml0
approved these changes
Oct 20, 2021
HOWTO.md
Outdated
| lower_tril_attention = BlockSparseAttention(layout=layout, block_size=BLOCK_SIZE, dropout=0.1) | ||
| causal_mask = torch.tril(torch.ones(SEQ, SEQ)).bool().cuda() | ||
| ... | ||
| att = lower_tril_attention(k, q, v, att_mask=causal_mask) |
There was a problem hiding this comment.
Worth showing that a key padding mask can be passed in as well and separately? Maybe not necessary for just this quick example
There was a problem hiding this comment.
I think that this could do with a second and third pass :) Would you mind adding that in another PR, re-reading some of this with an NLP perspective for instance ? I must have had quite a few blind spots
There was a problem hiding this comment.
Yes, I can do another pass :)
blefaudeux
force-pushed
the
doc_improvements
branch
from
515ed60 to
07ef1fc
Compare
blefaudeux
force-pushed
the
doc_improvements
branch
from
07ef1fc to
0f69a0e
Compare
blefaudeux
changed the title
xwhan
pushed a commit
to xwhan/xformers
that referenced
this pull request
Feb 8, 2022
[refactor] 3 lanes: `factory` for CI or programatic model building, `models` for presets and `components` block zoo. Dummy "Linformer" model example
qianfengz
added a commit
to qianfengz/xformers
that referenced
this pull request
Feb 7, 2024
Apply the existing linters (1/n)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Before submitting
PR review
Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.