Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[chore] Copyrights and link fixes #115

Merged
merged 1 commit into from
Nov 19, 2021

Conversation

blefaudeux
Copy link
Contributor

What does this PR do?

[FB] Should fix P468469851 and T106302092

Before submitting

  • Did you have fun?
    • Well, not really 🙃
  • Did you read the contributor guideline?
  • Was this discussed/approved via a Github issue? (no need for typos, doc improvements)
    • N/A
  • Did you make sure to update the docs?
    • N/A
  • Did you write any new necessary tests?
    • N/A
  • Did you update the changelog? (if needed)
    • N/A

PR review

Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Nov 19, 2021
Copy link
Contributor

@dianaml0 dianaml0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Ben!!

@codecov-commenter
Copy link

Codecov Report

Merging #115 (4a92a9f) into main (2d67cf2) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #115   +/-   ##
=======================================
  Coverage   87.22%   87.22%           
=======================================
  Files          49       49           
  Lines        2490     2490           
=======================================
  Hits         2172     2172           
  Misses        318      318           
Flag Coverage Δ
Python 87.22% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2d67cf2...4a92a9f. Read the comment docs.

@blefaudeux blefaudeux merged commit e045160 into main Nov 19, 2021
@blefaudeux blefaudeux deleted the fb_opensource_requriements_update branch November 19, 2021 18:57
xwhan pushed a commit to xwhan/xformers that referenced this pull request Feb 8, 2022
…s a fixed setting (facebookresearch#115)

- renaming
- additional cleanup, MHA does not own this
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants