Skip to content

Conversation

@magickenshin
Copy link

  • add interface for input target_dir
  • add reload button

1. add interface for input target_dir
2. add reload button
@facebook-github-bot
Copy link
Contributor

Hi @magickenshin!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at cla@meta.com. Thanks!

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Meta Open Source bot. label Mar 26, 2025
@facebook-github-bot
Copy link
Contributor

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks!

@jytime jytime self-assigned this Mar 30, 2025
@jytime
Copy link
Contributor

jytime commented Mar 30, 2025

Hi would you mind talking more about the goal of adding an extra reload button? It seems the visualisation will be auto-reloaded once some settings are changed.

@magickenshin
Copy link
Author

Hi, thanks for your great work! I think we could make it easier to compare camera positions and 3D points after running multiple datasets. Right now, when we finish a reconstruction, the points show up fine - but if I run a second dataset, I can't see the first result. Can we add a "reload" feature so we can always pull up an old reconstruction for comparison?

@jytime
Copy link
Contributor

jytime commented Mar 30, 2025

I see! That makes sense. Let me think for a while how should this be designed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Meta Open Source bot.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants