Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Objective.to() and TheseusLayer.to() now return self and support "cuda". #623

Merged
merged 2 commits into from
Nov 16, 2023
Merged

Objective.to() and TheseusLayer.to() now return self and support "cuda". #623

merged 2 commits into from
Nov 16, 2023

Conversation

luisenp
Copy link
Contributor

@luisenp luisenp commented Nov 3, 2023

Closes #622

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Nov 3, 2023
This was referenced Nov 3, 2023
Closed
Open
@luisenp luisenp merged commit 322807e into main Nov 16, 2023
15 checks passed
@luisenp luisenp deleted the lep.to_improvements branch November 16, 2023 18:39
mhmukadam
mhmukadam reviewed Nov 20, 2023
View reviewed changes
Copy link
Member

@mhmukadam mhmukadam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mhmukadam mhmukadam mhmukadam approved these changes

Assignees
No one assigned
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

TheseusLayer.to improvements: Return itself and support cuda
3 participants
@luisenp @mhmukadam @facebook-github-bot