Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tests for wheels in CI #354

Merged
merged 6 commits into from
Nov 8, 2022
Merged

Add tests for wheels in CI #354

merged 6 commits into from
Nov 8, 2022

Conversation

luisenp
Copy link
Contributor

@luisenp luisenp commented Nov 7, 2022

No description provided.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Nov 7, 2022
@luisenp luisenp force-pushed the lep.ci_wheel_tests branch 3 times, most recently from 2b1c6d4 to 10df838 Compare November 7, 2022 16:14
@luisenp luisenp force-pushed the lep.ci_wheel_tests branch 3 times, most recently from a444393 to 773f8c1 Compare November 7, 2022 17:26
@luisenp luisenp marked this pull request as ready for review November 7, 2022 18:43
@luisenp
Copy link
Contributor Author

luisenp commented Nov 7, 2022

@maurimo Do you have any suggestions for fixing the CUDA 10 wheel test? It's failing when compiling Baspacho. The script works for me locally, not sure why it's failing in CI.

Copy link
Member

@mhmukadam mhmukadam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. License header for new init file is missing :P

@luisenp luisenp force-pushed the lep.ci_wheel_tests branch 3 times, most recently from 6dd81e9 to 2d5b5d9 Compare November 8, 2022 00:40
@luisenp luisenp force-pushed the lep.ci_wheel_tests branch 5 times, most recently from db77552 to 42e7a3e Compare November 8, 2022 13:36
@luisenp luisenp merged commit 07a59e5 into main Nov 8, 2022
@luisenp luisenp deleted the lep.ci_wheel_tests branch November 8, 2022 17:06
suddhu pushed a commit to suddhu/theseus that referenced this pull request Jan 21, 2023
* Added circleci job for testing cuda 11 wheel

* Changed build script so that one can pass a commit ID.

* Fixed errors in CI job for wheels.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants