Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update contrib and add gitattributes #33

Merged
merged 2 commits into from
Dec 22, 2021
Merged

Update contrib and add gitattributes #33

merged 2 commits into from
Dec 22, 2021

Conversation

mhmukadam
Copy link
Member

  • Update contributing file to the branching model we follow.
  • Added gitattribute file (to ignore .pynb files) to display correct language on landing page.

@mhmukadam mhmukadam added documentation Improvements or additions to documentation CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. labels Dec 21, 2021
@mhmukadam mhmukadam added this to the 0.1.0-b.2 milestone Dec 21, 2021
@mhmukadam mhmukadam self-assigned this Dec 21, 2021
luisenp
luisenp approved these changes Dec 22, 2021
View reviewed changes
Copy link
Contributor

@luisenp luisenp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. And thanks for adding the linguist-documentation stuff, that Jupyter % is annoying me! :)

@mhmukadam mhmukadam merged commit 3b3ba0f into main Dec 22, 2021
@mhmukadam mhmukadam deleted the mhm.contrib branch December 22, 2021 19:16
ddetone pushed a commit that referenced this pull request Mar 29, 2022
@vshobha
Merge pull request #33 from fairinternal/shobha.nn_precision_test
1f0d9aa 
Added NNPrecision test
suddhu pushed a commit to suddhu/theseus that referenced this pull request Jan 21, 2023
@mhmukadam
Update contrib and add gitattributes (facebookresearch#33)
703965c
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@luisenp luisenp luisenp approved these changes

Assignees

@mhmukadam mhmukadam

Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. documentation Improvements or additions to documentation
Projects
None yet
Milestone
0.1.0-b.2
Development

Successfully merging this pull request may close these issues.
2 participants
@mhmukadam @luisenp