Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename BackwardMode.FULL --> UNROLL and simplify backward mode config #305

Merged
merged 2 commits into from
Sep 27, 2022
Merged

Rename BackwardMode.FULL --> UNROLL and simplify backward mode config #305

merged 2 commits into from
Sep 27, 2022

Conversation

luisenp
Copy link
Contributor

@luisenp luisenp commented Sep 26, 2022

We can now pass strings to specify backward modes, instead of having to pass the specific enum type.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Sep 26, 2022
@luisenp luisenp changed the title Rename BackwardModel.FULL --> UNROLL and simplify backward mode config Rename BackwardMode.FULL --> UNROLL and simplify backward mode config Sep 26, 2022
mhmukadam
mhmukadam approved these changes Sep 27, 2022
View reviewed changes
Copy link
Member

@mhmukadam mhmukadam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

@luisenp luisenp merged commit a18eec7 into main Sep 27, 2022
@luisenp luisenp deleted the lep.simplify_backward_mode_cfg branch September 27, 2022 18:11
suddhu pushed a commit to suddhu/theseus that referenced this pull request Jan 21, 2023
@luisenp
Rename BackwardMode.FULL --> UNROLL and simplify backward mode config (…
187a058 
…facebookresearch#305)

* Added code so that backward mode can be resolved from string.

* Replaced BackwardMode.FULL for BackwardModel.UNROLL.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mhmukadam mhmukadam mhmukadam approved these changes

@fantaosha fantaosha Awaiting requested review from fantaosha

Assignees
No one assigned
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@luisenp @mhmukadam @facebook-github-bot