Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added option to clear cuda cache when vectorization cache is cleared. #249

Merged
merged 2 commits into from
Jul 19, 2022
Merged

Added option to clear cuda cache when vectorization cache is cleared. #249

merged 2 commits into from
Jul 19, 2022

Conversation

luisenp
Copy link
Contributor

@luisenp luisenp commented Jul 18, 2022

No description provided.

@luisenp luisenp self-assigned this Jul 18, 2022
@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Jul 18, 2022
fantaosha
fantaosha reviewed Jul 18, 2022
View reviewed changes
Copy link
Contributor

@fantaosha fantaosha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Some minor comments.

examples/configs/pose_graph/pose_graph_synthetic.yaml Show resolved Hide resolved
examples/pose_graph/pose_graph_synthetic.py Show resolved Hide resolved
theseus/theseus_layer.py Show resolved Hide resolved
mhmukadam
mhmukadam approved these changes Jul 18, 2022
View reviewed changes
Copy link
Member

@mhmukadam mhmukadam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks for figuring this out and for the quick fix.

@fantaosha fantaosha self-requested a review July 19, 2022 20:52
fantaosha
fantaosha approved these changes Jul 19, 2022
View reviewed changes
Copy link
Contributor

@fantaosha fantaosha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@mhmukadam mhmukadam merged commit 85f7529 into main Jul 19, 2022
@mhmukadam mhmukadam deleted the lep.add_optional_clear_cuda_cache branch July 19, 2022 21:01
suddhu pushed a commit to suddhu/theseus that referenced this pull request Jan 21, 2023
@luisenp
Added option to clear cuda cache when vectorization cache is cleared. (…
d18f61f 
…facebookresearch#249)

* Added option to clear cuda cache when vectorization cache is cleared.

* Changed PGO synthetic script to have the option to empty cuda cache.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mhmukadam mhmukadam mhmukadam approved these changes

@fantaosha fantaosha fantaosha approved these changes

Assignees

@luisenp luisenp

Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@luisenp @mhmukadam @fantaosha @facebook-github-bot