Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Moved Vectorize(objective) to the Optimizer class. #218

Merged
merged 5 commits into from
Jun 16, 2022
Merged

Moved Vectorize(objective) to the Optimizer class. #218

merged 5 commits into from
Jun 16, 2022

Conversation

luisenp
Copy link
Contributor

@luisenp luisenp commented Jun 15, 2022

Note that the old stand-alone optimizer tests have vectorize=False because the copy method of the CostFunction used is not implemented. It's kind of a pain to implement it for not a lot of added value, since the end-to-end and backward tests do use vectorization.

@luisenp luisenp self-assigned this Jun 15, 2022
@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Jun 15, 2022
mhmukadam
mhmukadam reviewed Jun 15, 2022
View reviewed changes
theseus/theseus_layer.py Outdated Show resolved Hide resolved
@luisenp
Copy link
Contributor Author

luisenp commented Jun 15, 2022

Squeezing in a quick fix for a flaky unit tests in RobustCostFunction.

fantaosha
fantaosha approved these changes Jun 15, 2022
View reviewed changes
Copy link
Contributor

@fantaosha fantaosha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM overall.

theseus/theseus_layer.py Outdated Show resolved Hide resolved
@luisenp luisenp force-pushed the lep.move_vectorize_to_optimizer branch from 7fe1a85 to 7086112 Compare June 16, 2022 14:51
@luisenp luisenp force-pushed the lep.move_vectorize_to_optimizer branch from 7086112 to 8c12f68 Compare June 16, 2022 14:51
fantaosha
fantaosha approved these changes Jun 16, 2022
View reviewed changes
Copy link
Contributor

@fantaosha fantaosha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@luisenp luisenp merged commit ce6e127 into main Jun 16, 2022
@luisenp luisenp deleted the lep.move_vectorize_to_optimizer branch June 16, 2022 15:13
suddhu pushed a commit to suddhu/theseus that referenced this pull request Jan 21, 2023
@luisenp
Moved Vectorize(objective) to the Optimizer class. (facebookresearch#218
a1a5d38 
)

* Moved Vectorize(objective) to the Optimizer class.

* Vectorized tests for nonlinear optimizers.

* Small fixes.

* Fix flaky unit test.

* Added option to vectorize objective from TheseusLayer.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mhmukadam mhmukadam mhmukadam approved these changes

@fantaosha fantaosha fantaosha approved these changes

Assignees

@luisenp luisenp

Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@luisenp @mhmukadam @fantaosha @facebook-github-bot