Moved the method that retracts all variables with a given delta to Objective #214
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
mhmukadam
reviewed
Jun 12, 2022
mhmukadam
reviewed
Jun 12, 2022
mhmukadam
reviewed
Jun 12, 2022
mhmukadam
approved these changes
Jun 12, 2022
rtqichen
approved these changes
Jun 14, 2022
mhmukadam
approved these changes
Jun 14, 2022
suddhu
pushed a commit
to suddhu/theseus
that referenced
this pull request
Jan 21, 2023
…jective (facebookresearch#214) * Moved the method that retracts all variables with a given delta to Objective. * Renamed step_optim_vars as retract_optim_vars.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We have talked for quite a while about where to place this method. Proposing the solution in this PR. Planning to use this as the starting point for the vectorized retraction maps.