Fixing Windows MSVC Compatibility

[yuanluxu]

🐛 Bugs / Unexpected behaviors

Fixed Windows MSVC build compatibility issues. All tests passed.

If you are using pre-compiled pytorch 1.4 and torchvision 0.5. You should make the following revisions to the pytorch source codes also to successfully compile with visual studio 2019 (MSVC 19.16.27034) and CUDA 10.1.

1. Change python/Lib/site-packages/torch/include/csrc/jit/script/module.h

• L466, 476, 493, 506, 536
  -static constexpr *
+static const *

2. Change python/Lib/site-packages/torch/include/csrc/jit/argument_spec.h

• L190
  -static constexpr size_t DEPTH_LIMIT = 128;
+static const size_t DEPTH_LIMIT = 128;

3. Change python/Lib/site-packages/torch/include/pybind11/cast.h

• L1449
  -explicit operator type&() { return *(this->value); }
+explicit operator type& () { return *((type*)(this->value)); }

If you are using CUDA 10.2 with pre-compiled pytorch 1.4 and torchvision 0.5, you need to check
Pytorch Issue [(https://github.com/pytorch/pytorch/issues/33203)] for patching the pytorch source code in addition.

Instructions To Reproduce the Issue:

Please include the following (depending on what the issue is):

1. Any changes you made (git diff) or code you wrote

https://github.com/facebookresearch/pytorch3d/pull/9

2. The exact command(s) you ran:
3. What you observed (including the full logs):

<put logs here>

Please also simplify the steps as much as possible so they do not require additional resources to
run, such as a private dataset.

[srxdev0619]

Hi,

I get the following errors while trying to install Pytorch3d

c:/users/shahrukh/anaconda3/lib/site-packages/torch/include\c10/util/BFloat16.h(48): warning: calling a __host__ function from a __host__ __device__ function is not allowed

C:\Users\ShahRukh\Research\pytorch3d\pytorch3d\csrc\rasterize_meshes\geometry_utils.cuh(231): error: identifier "kEpsilon" is undefined in device code

C:/Users/ShahRukh/Research/pytorch3d/pytorch3d/csrc/rasterize_meshes/rasterize_meshes.cu(391): error: identifier "kEpsilon" is undefined in device code

C:/Users/ShahRukh/Research/pytorch3d/pytorch3d/csrc/rasterize_meshes/rasterize_meshes.cu(427): error: identifier "kEpsilon" is undefined in device code

C:/Users/ShahRukh/Research/pytorch3d/pytorch3d/csrc/rasterize_meshes/rasterize_meshes.cu(427): error: calling a __host__ function("pow<float, double, void> ") from a __global__ function("RasterizeMeshesBackwardCudaKernel") is not allowed

C:/Users/ShahRukh/Research/pytorch3d/pytorch3d/csrc/rasterize_meshes/rasterize_meshes.cu(427): error: identifier "pow<float, double, void> " is undefined in device code

C:/Users/ShahRukh/Research/pytorch3d/pytorch3d/csrc/rasterize_meshes/rasterize_meshes.cu(133): error: identifier "kEpsilon" is undefined in device code

C:/Users/ShahRukh/Research/pytorch3d/pytorch3d/csrc/rasterize_meshes/rasterize_meshes.cu(133): error: identifier "kEpsilon" is undefined in device code

C:/Users/ShahRukh/Research/pytorch3d/pytorch3d/csrc/rasterize_meshes/rasterize_meshes.cu(141): error: identifier "kEpsilon" is undefined in device code
8 errors detected in the compilation of "C:/Users/ShahRukh/AppData/Local/Temp/tmpxft_000026f0_00000000-10_rasterize_meshes.cpp1.ii".
    rasterize_meshes.cu
    error: command 'C:\\Program Files\\NVIDIA GPU Computing Toolkit\\CUDA\\v10.1\\bin\\nvcc.exe' failed with exit status 1
    ----------------------------------------
ERROR: Command errored out with exit status 1: 'c:\users\shahrukh\anaconda3\python.exe' -c 'import sys, setuptools, tokenize; sys.argv[0] = '"'"'C:\\Users\\ShahRukh\\Research\\pytorch3d\\setup.py'"'"'; __file__='"'"'C:\\Users\\ShahRukh\\Research\\pytorch3d\\setup.py'"'"';f=getattr(tokenize, '"'"'open'"'"', open)(__file__);code=f.read().replace('"'"'\r\n'"'"', '"'"'\n'"'"');f.close();exec(compile(code, __file__, '"'"'exec'"'"'))' develop --no-deps Check the logs for full command output.

The installation commands I ran were the following, in the order of execution

conda install -c pytorch pytorch torchvision cudatoolkit=10.1
conda install -c conda-forge -c fvcore fvcore

pip install scikit-image matplotlib imageio

git clone https://github.com/facebookresearch/pytorch3d.git
cd pytorch3d
pip install -e .

I'm using Visual Studio 2019 Community. It'd be great if these errors could be fixed. Thank you!

[yuanluxu]

Hi @srxdev0619, I believe I fixed this issue in my fork. You can clone my folk and re-compile it.
https://github.com/yuanluxu/pytorch3d

[srxdev0619]

Yes! The fix works perfectly, thank you so much!