This repository was archived by the owner on Nov 22, 2022. It is now read-only.
config adapter helper functions #896
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary: we use the function eprint to print to stderr. This diff moves this function to a utils class and we change a few (stdout) print to (stderr) eprint. This gives a cleaner output when piping to files. Differential Revision: D16749170 fbshipit-source-id: c3935f515a5463ae05aa90ecb6ad66192ba55a08
Summary: config adapter has a very powerfull function `rename_parameter`. This diff splits this function to expose its inner functions that can be useful for more than just renaming parameters. These new functions will be used in the next diff in the stack Differential Revision: D16749189 fbshipit-source-id: 8a61eaf289d0627af438c9568b16ba2103604fa5
facebook-github-bot
added
the
CLA Signed
|
This pull request has been merged in 0217d4f. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
config adapter has a very powerfull function
rename_parameter.This diff splits this function to expose its inner functions that can be
useful for more than just renaming parameters.
These new functions will be used in the next diff in the stack
Differential Revision: D16749189