This repository was archived by the owner on Nov 22, 2022. It is now read-only.
Delete JointTextTask #886
Closed
Delete JointTextTask #886
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
geof90
force-pushed
the
export-D16708085
branch
from
e00ba4c to
29302b7
Compare
geof90
added a commit
to geof90/pytext
that referenced
this pull request
Aug 8, 2019
Summary: Pull Request resolved: facebookresearch#886 Part4 of code deletion to remove deprecated joint model. JointTextTask is removed in place of IntentSlotTask Differential Revision: D16708085 fbshipit-source-id: 76bf305274738f57492484a13594a5b48c1f2f56
geof90
force-pushed
the
export-D16708085
branch
from
29302b7 to
ccde721
Compare
geof90
added a commit
to geof90/pytext
that referenced
this pull request
Aug 8, 2019
Summary: Pull Request resolved: facebookresearch#886 Part4 of code deletion to remove deprecated joint model. JointTextTask is removed in place of IntentSlotTask Can't get rid of JointModel since Wit uses it, also JointDataHandler is used in a bunch of word tagging models, so will remove those in later diffs. Differential Revision: D16708085 fbshipit-source-id: b280ba7766cca9f6dd3d2fdbb0e322ce66c09362
geof90
force-pushed
the
export-D16708085
branch
from
ccde721 to
df5db50
Compare
geof90
added a commit
to geof90/pytext
that referenced
this pull request
Aug 8, 2019
Summary: Pull Request resolved: facebookresearch#886 Part4 of code deletion to remove deprecated joint model. JointTextTask is removed in place of IntentSlotTask Can't get rid of JointModel since Wit uses it, also JointDataHandler is used in a bunch of word tagging models, so will remove those in later diffs. Differential Revision: D16708085 fbshipit-source-id: dd0e8b49905ed268bf5b36479c6837a987ed776b
geof90
force-pushed
the
export-D16708085
branch
from
df5db50 to
8e4013c
Compare
geof90
added a commit
to geof90/pytext
that referenced
this pull request
Aug 9, 2019
Summary: Pull Request resolved: facebookresearch#886 Part4 of code deletion to remove deprecated joint model. JointTextTask is removed in place of IntentSlotTask Can't get rid of JointModel since Wit uses it, also JointDataHandler is used in a bunch of word tagging models, so will remove those in later diffs. Differential Revision: D16708085 fbshipit-source-id: ea594b32306d67b71891e60863c42f32851f7368
geof90
force-pushed
the
export-D16708085
branch
from
8e4013c to
0f0bb98
Compare
geof90
added a commit
to geof90/pytext
that referenced
this pull request
Aug 9, 2019
Summary: Pull Request resolved: facebookresearch#886 Part4 of code deletion to remove deprecated joint model. JointTextTask is removed in place of IntentSlotTask Can't get rid of JointModel since Wit uses it, also JointDataHandler is used in a bunch of word tagging models, so will remove those in later diffs. Differential Revision: D16708085 fbshipit-source-id: 1d0443a6f99e3210b5ad5dcd6b20c38d29463e84
geof90
force-pushed
the
export-D16708085
branch
from
0f0bb98 to
12acf9f
Compare
geof90
added a commit
to geof90/pytext
that referenced
this pull request
Aug 9, 2019
Summary: Pull Request resolved: facebookresearch#886 Part4 of code deletion to remove deprecated joint model. JointTextTask is removed in place of IntentSlotTask Can't get rid of JointModelDataHandler since Wit uses it, also JointDataHandler is used in a bunch of word tagging models, so will remove those in later diffs. Differential Revision: D16708085 fbshipit-source-id: 6eb17e486cd63bcc48da3dce98121d6cef66a50a
geof90
force-pushed
the
export-D16708085
branch
from
12acf9f to
d37d21d
Compare
geof90
added a commit
to geof90/pytext
that referenced
this pull request
Aug 9, 2019
Summary: Pull Request resolved: facebookresearch#886 Part4 of code deletion to remove deprecated joint model. JointTextTask is removed in place of IntentSlotTask Can't get rid of JointModelDataHandler since Wit uses it, also JointDataHandler is used in a bunch of word tagging models, so will remove those in later diffs. Differential Revision: D16708085 fbshipit-source-id: 369815ecb42e1428bd42deb0e1bb670c5703894c
geof90
force-pushed
the
export-D16708085
branch
from
d37d21d to
72fd814
Compare
geof90
added a commit
to geof90/pytext
that referenced
this pull request
Aug 9, 2019
Summary: Pull Request resolved: facebookresearch#886 Part4 of code deletion to remove deprecated joint model. JointTextTask is removed in place of IntentSlotTask Can't get rid of JointModelDataHandler since Wit uses it, also JointDataHandler is used in a bunch of word tagging models, so will remove those in later diffs. Differential Revision: D16708085 fbshipit-source-id: f6dfbc96771851a1897a95f74025cf572cdb0b44
geof90
force-pushed
the
export-D16708085
branch
from
72fd814 to
2813b87
Compare
geof90
added a commit
to geof90/pytext
that referenced
this pull request
Aug 9, 2019
Summary: Pull Request resolved: facebookresearch#886 Part4 of code deletion to remove deprecated joint model. JointTextTask is removed in place of IntentSlotTask Can't get rid of JointModelDataHandler since Wit uses it, also JointDataHandler is used in a bunch of word tagging models, so will remove those in later diffs. Differential Revision: D16708085 fbshipit-source-id: d26bd4492b86c35f93bc830fa7315b1ae17257c4
geof90
force-pushed
the
export-D16708085
branch
from
2813b87 to
54279c6
Compare
geof90
added a commit
to geof90/pytext
that referenced
this pull request
Aug 11, 2019
Summary: Pull Request resolved: facebookresearch#886 Part4 of code deletion to remove deprecated joint model. JointTextTask is removed in place of IntentSlotTask Can't get rid of JointModelDataHandler since Wit uses it, also JointDataHandler is used in a bunch of word tagging models, so will remove those in later diffs. Differential Revision: D16708085 fbshipit-source-id: edb0c939b1a32cec790096389158b869611ac066
Summary: Abhinav confirmed this is not used. Part1 of code deletion to remove deprecated joint model. Differential Revision: D16686409 fbshipit-source-id: 6fde49caf73f6b5051be57c250a95069a3a02f3f
Summary: Part3 of code deletion to remove deprecated joint model. Differential Revision: D16694571 fbshipit-source-id: 4baab59027c05ce419462b643f8e9f214d1af4d8
Summary: Pull Request resolved: facebookresearch#886 Part4 of code deletion to remove deprecated joint model. JointTextTask is removed in place of IntentSlotTask Can't get rid of JointModelDataHandler since Wit uses it, also JointDataHandler is used in a bunch of word tagging models, so will remove those in later diffs. Differential Revision: D16708085 fbshipit-source-id: 6b8663c67a20c5b40c256546e4c43a0b039890ec
geof90
force-pushed
the
export-D16708085
branch
from
54279c6 to
99eea09
Compare
|
This pull request has been merged in c211463. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary: Part4 of code deletion to remove deprecated joint model. JointTextTask is removed in place of IntentSlotTask
Differential Revision: D16708085