This repository has been archived by the owner on Nov 22, 2022. It is now read-only.
fix - test flow only works with TSVDataSource #448
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
borguz
added a commit
to borguz/pytext-1
that referenced
this pull request
Apr 4, 2019
Summary: Pull Request resolved: facebookresearch#448 This diff D14526577 enabled passing test file for new task, but works only with TSVDataSource. Generalize it so it works for other data sources. Differential Revision: D14781441 fbshipit-source-id: 5fd30d69c835ec7b40250a4a277bba80e592df49
Summary: Pull Request resolved: facebookresearch#448 This diff D14526577 enabled passing test file for new task, but works only with TSVDataSource. Generalize it so it works for other data sources. Differential Revision: D14781441 fbshipit-source-id: cfa98f6b78482933ba490a8fe8aafa9597869108
|
This pull request has been merged in f501bf9. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary: This diff D14526577 enabled passing test file for new task, but works only with TSVDataSource. Generalize it so it works for other data sources.
Differential Revision: D14781441