This repository has been archived by the owner on Nov 22, 2022. It is now read-only.
rename MetaInput to RawString #428
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
Titousensei
force-pushed
the
export-D14654966
branch
from
8aa0d78
to
f9839a7
Compare
Titousensei
added a commit
to Titousensei/pytext
that referenced
this pull request
Mar 28, 2019
Summary: Pull Request resolved: facebookresearch#428 renaming MetaInput to RawString, and JsonMetaInput to RawJson. These are pass-through Tokenizers that just copy their inputs. The name "MetaInput" does not mean anything, RawString and RawJson at least give you a hint about what they're doing. Differential Revision: D14654966 fbshipit-source-id: 39f82614ff1d5a5772164e0b63518e0d326e2d4b
Summary: Pull Request resolved: facebookresearch#428 renaming MetaInput to RawString, and JsonMetaInput to RawJson. These are pass-through Tokenizers that just copy their inputs. The name "MetaInput" does not mean anything, RawString and RawJson at least give you a hint about what they're doing. Reviewed By: bethebunny Differential Revision: D14654966 fbshipit-source-id: 218ee39bdec0d6be09007d9322a2013a5e5bbcc9
Titousensei
force-pushed
the
export-D14654966
branch
from
f9839a7
to
18d1f20
Compare
|
This pull request has been merged in b21c407. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
renaming MetaInput to RawString, and JsonMetaInput to RawJson.
These are pass-through Tokenizers that just copy their inputs. The name
"MetaInput" does not mean anything, RawString and RawJson at least give you
a hint about what they're doing.
Differential Revision: D14654966