This repository has been archived by the owner on Nov 22, 2022. It is now read-only.
Performance improvement in metrics calculations #409
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary: Metrics calculation for doc classification takes much longer than the training itself: x34 of the training time! This simple diff improves the metrics time significantly by fixing the low-hanging fruit of bool->int casting. It's still taking the majority of the time (x9 only!), so it will need further improvements. Differential Revision: D14474255 fbshipit-source-id: 29eb85b62e5e6e6799f0385f16ed1fcdce7d7543
facebook-github-bot
added
the
CLA Signed
|
This pull request has been merged in a22981a. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Metrics calculation for doc classification takes much longer than the training itself: x34 of the training time!
This simple diff improves the metrics time significantly by fixing the low-hanging fruit of bool->int casting.
It's still taking the majority of the time (x9 only!), so it will need further improvements.
Differential Revision: D14474255