This repository was archived by the owner on Nov 22, 2022. It is now read-only.
Move random_seed out of task, into PyTextConfig #275
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary: random_seed isn't task specific and the task doesn't need or use it for anything (except the assertions, which I don't think are particularly valuable). I'm moving this to the PyTextConfig which to me is a more sensible place to put it. Differential Revision: D13998158 fbshipit-source-id: f57e8b45a70ed15c4bf6911afd97402f2dbac468
facebook-github-bot
added
the
CLA Signed
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary: random_seed isn't task specific and the task doesn't need or use it for anything (except the assertions, which I don't think are particularly valuable). I'm moving this to the PyTextConfig which to me is a more sensible place to put it.
Differential Revision: D13998158