This repository was archived by the owner on Nov 22, 2022. It is now read-only.
Data Handler Rewrite [1/x]: Data Source #272
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
bethebunny
force-pushed
the
export-D13870556
branch
from
1ceb68f to
a78effa
Compare
bethebunny
added a commit
to bethebunny/pytext-1
that referenced
this pull request
Feb 7, 2019
Summary: Pull Request resolved: facebookresearch#272 Basic Data Source and TSV data source implementation. 2 remaining things to do before this is landed: 1. targets files 2. more unit tests Reviewed By: borguz Differential Revision: D13870556 fbshipit-source-id: bf6b6e094853867d4ce6037d022bf131baa3fc34
bethebunny
force-pushed
the
export-D13870556
branch
from
a78effa to
1810ba7
Compare
bethebunny
added a commit
to bethebunny/pytext-1
that referenced
this pull request
Feb 7, 2019
Summary: Pull Request resolved: facebookresearch#272 Basic Data Source and TSV data source implementation. 2 remaining things to do before this is landed: 1. targets files 2. more unit tests Reviewed By: borguz Differential Revision: D13870556 fbshipit-source-id: 0f43a8b3e9efc6dc17098376b2ec2c21a040fba0
bethebunny
force-pushed
the
export-D13870556
branch
from
1810ba7 to
595482a
Compare
bethebunny
added a commit
to bethebunny/pytext-1
that referenced
this pull request
Feb 8, 2019
Summary: Pull Request resolved: facebookresearch#272 Basic Data Source and TSV data source implementation. 2 remaining things to do before this is landed: 1. targets files 2. more unit tests Reviewed By: borguz Differential Revision: D13870556 fbshipit-source-id: ef6a0afb714fcc9b21341d7ef7c416b754c6d8cd
bethebunny
force-pushed
the
export-D13870556
branch
from
595482a to
d12b4c6
Compare
bethebunny
added a commit
to bethebunny/pytext-1
that referenced
this pull request
Feb 8, 2019
Summary: Pull Request resolved: facebookresearch#272 Basic Data Source and TSV data source implementation. 2 remaining things to do before this is landed: 1. targets files 2. more unit tests Reviewed By: borguz Differential Revision: D13870556 fbshipit-source-id: 8d5e56aa2b98f3e9149267de133f9eadbf206584
bethebunny
force-pushed
the
export-D13870556
branch
from
d12b4c6 to
5b777ae
Compare
bethebunny
added a commit
to bethebunny/pytext-1
that referenced
this pull request
Feb 8, 2019
Summary: Pull Request resolved: facebookresearch#272 Basic Data Source and TSV data source implementation. 2 remaining things to do before this is landed: 1. targets files 2. more unit tests Differential Revision: D13870556 fbshipit-source-id: 7d38af45795e24b6d3dbd1012db4c41dbf336c86
Summary: Pull Request resolved: facebookresearch#272 Basic Data Source and TSV data source implementation. 2 remaining things to do before this is landed: 1. targets files 2. more unit tests Reviewed By: m3rlin45 Differential Revision: D13870556 fbshipit-source-id: 5f3ec6ae6c3dc66648733226a01b0597d8f2a104
bethebunny
force-pushed
the
export-D13870556
branch
from
5b777ae to
33fae35
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Basic Data Source and TSV data source implementation.
2 remaining things to do before this is landed:
Differential Revision: D13870556