This repository was archived by the owner on Nov 22, 2022. It is now read-only.
make predict_iter support running through multiple batches #251
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary: This diff adds a flow for offline prediction using pytext models, making predict_iter support running through multiple batches and it also has a minor fix for glue_benchmark script. Differential Revision: D13831370 fbshipit-source-id: d532a976c0a8881fd51a8a913d19465f9c958c6d
facebook-github-bot
added
the
CLA Signed
liaimi
changed the title
gthb
reviewed
Feb 5, 2019
| # only return the first batch since there is only one | ||
| return input, context | ||
| if batch_size is not None: | ||
| return it |
There was a problem hiding this comment.
This breaks Task.predict and thus pytext predict-py, as a 2-tuple is assumed to be returned. Also the if-predicate is always true because batch_size gets defaulted to len(ds) above.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary: This diff adds a flow for offline prediction using pytext models, making predict_iter support running through multiple batches and it also has a minor fix for glue_benchmark script.
Differential Revision: D13831370