This repository was archived by the owner on Nov 22, 2022. It is now read-only.
Refactor metric_reporters #245
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
Titousensei
force-pushed
the
export-D13829608
branch
from
17af47a to
0de8b48
Compare
Titousensei
added a commit
to Titousensei/pytext
that referenced
this pull request
Jan 26, 2019
Summary: Pull Request resolved: facebookresearch#245 we're passing around SummaryWriter everywhere. This is a TensorBoard-specific internal parameter that should be isolated to the TensorBoardChannel class. This is because metric reporters channels are actually resources that need to be closed after using them. This implementation makes it difficult to add new metric reporter channels that are additions to and alternatives of TensorBoard. This diff refactors how metric reporters are passed around and improves modularity and separation of concerns. Differential Revision: D13829608 fbshipit-source-id: 463c34205582ff80fd6d319bee60ac147cc19852
Titousensei
force-pushed
the
export-D13829608
branch
from
0de8b48 to
c149d12
Compare
Titousensei
added a commit
to Titousensei/pytext
that referenced
this pull request
Jan 30, 2019
Summary: Pull Request resolved: facebookresearch#245 we're passing around SummaryWriter everywhere. This is a TensorBoard-specific internal parameter that should be isolated to the TensorBoardChannel class. This is because metric reporters channels are actually resources that need to be closed after using them. This implementation makes it difficult to add new metric reporter channels that are additions to and alternatives of TensorBoard. This diff refactors how metric reporters are passed around and improves modularity and separation of concerns. Differential Revision: D13829608 fbshipit-source-id: d2034bf670350f4cfb5338f7baa628887e131304
Titousensei
force-pushed
the
export-D13829608
branch
from
c149d12 to
96c9f4a
Compare
Titousensei
added a commit
to Titousensei/pytext
that referenced
this pull request
Jan 30, 2019
Summary: Pull Request resolved: facebookresearch#245 we're passing around SummaryWriter everywhere. This is a TensorBoard-specific internal parameter that should be isolated to the TensorBoardChannel class. This is because metric reporters channels are actually resources that need to be closed after using them. This implementation makes it difficult to add new metric reporter channels that are additions to and alternatives of TensorBoard. This diff refactors how metric reporters are passed around and improves modularity and separation of concerns. Differential Revision: D13829608 fbshipit-source-id: bfe2c6cf5e6f515149057468ebf2f01c992164a3
Titousensei
force-pushed
the
export-D13829608
branch
from
96c9f4a to
7264ec8
Compare
Titousensei
added a commit
to Titousensei/pytext
that referenced
this pull request
Jan 30, 2019
Summary: Pull Request resolved: facebookresearch#245 we're passing around SummaryWriter everywhere. This is a TensorBoard-specific internal parameter that should be isolated to the TensorBoardChannel class. This is because metric reporters channels are actually resources that need to be closed after using them. This implementation makes it difficult to add new metric reporter channels that are additions to and alternatives of TensorBoard. This diff refactors how metric reporters are passed around and improves modularity and separation of concerns. Differential Revision: D13829608 fbshipit-source-id: 5f681273cfe97be529da7bcc4df888a4814694c4
Titousensei
force-pushed
the
export-D13829608
branch
3 times, most recently
from
828e3da to
946603f
Compare
Titousensei
added a commit
to Titousensei/pytext
that referenced
this pull request
Feb 1, 2019
Summary: Pull Request resolved: facebookresearch#245 we're passing around SummaryWriter everywhere. This is a TensorBoard-specific internal parameter that should be isolated to the TensorBoardChannel class. This is because metric reporters channels are actually resources that need to be closed after using them. This implementation makes it difficult to add new metric reporter channels that are additions to and alternatives of TensorBoard. This diff refactors how metric reporters are passed around and improves modularity and separation of concerns. Differential Revision: D13829608 fbshipit-source-id: 10820668357fb83c39b37a68eef635830d2aa60d
Titousensei
force-pushed
the
export-D13829608
branch
from
946603f to
fd9d6f7
Compare
Titousensei
added a commit
to Titousensei/pytext
that referenced
this pull request
Feb 1, 2019
Summary: Pull Request resolved: facebookresearch#245 we're passing around SummaryWriter everywhere. This is a TensorBoard-specific internal parameter that should be isolated to the TensorBoardChannel class. This is because metric reporters channels are actually resources that need to be closed after using them. This implementation makes it difficult to add new metric reporter channels that are additions to and alternatives of TensorBoard. This diff refactors how metric reporters are passed around and improves modularity and separation of concerns. Differential Revision: D13829608 fbshipit-source-id: f559340726e5ce36b38b75202115b06670f8b0e2
Summary: Pull Request resolved: facebookresearch#245 we're passing around SummaryWriter everywhere. This is a TensorBoard-specific internal parameter that should be isolated to the TensorBoardChannel class. This is because metric reporters channels are actually resources that need to be closed after using them. This implementation makes it difficult to add new metric reporter channels that are additions to and alternatives of TensorBoard. This diff refactors how metric reporters are passed around and improves modularity and separation of concerns. Reviewed By: geof90 Differential Revision: D13829608 fbshipit-source-id: e16a25e174510be5aeae1cb38c34460796f4c46b
Titousensei
force-pushed
the
export-D13829608
branch
from
fd9d6f7 to
3f2d058
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
we're passing around SummaryWriter everywhere. This is a
TensorBoard-specific internal parameter that should be isolated to the
TensorBoardChannel class. This is because metric reporters channels are
actually resources that need to be closed after using them.
This implementation makes it difficult to add new metric reporter channels
that are additions to and alternatives of TensorBoard. This diff refactors
how metric reporters are passed around and improves modularity and
separation of concerns.
Differential Revision: D13829608