This repository was archived by the owner on Nov 22, 2022. It is now read-only.
default config for JointTextTask #211
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
Titousensei
force-pushed
the
export-D13441705
branch
from
6164712 to
8b0d03c
Compare
Titousensei
added a commit
to Titousensei/pytext
that referenced
this pull request
Jan 17, 2019
Summary: Pull Request resolved: facebookresearch#211 because fblearner is confused about types List[Union], we can't give a default value to those Config parameters and we leave them empty. That's a problem for gen_default_config, which relies on instanciating components with default values. So those configs, like JointTextTask, can't be used with gen_default_config. This diff introduces a generic solution for Tasks like this (not for all components, coming soon) by allowing each task to provide an optional function "example_config" that returns a Config object with default values suitable for gen_default_config. This default values for List[Union] should be a list of each possible class of the union, to give a complete example that users can edit at their convenience. We solve the case of JointTextTask as an example. Other tasks will be solved in following diffs. Differential Revision: D13441705 fbshipit-source-id: 3474985df195f69034109328b4c305502ddbdfe3
Titousensei
force-pushed
the
export-D13441705
branch
from
8b0d03c to
0b41756
Compare
Titousensei
added a commit
to Titousensei/pytext
that referenced
this pull request
Jan 17, 2019
Summary: Pull Request resolved: facebookresearch#211 because fblearner is confused about types List[Union], we can't give a default value to those Config parameters and we leave them empty. That's a problem for gen_default_config, which relies on instanciating components with default values. So those configs, like JointTextTask, can't be used with gen_default_config. This diff introduces a generic solution for Tasks like this (not for all components, coming soon) by allowing each task to provide an optional function "example_config" that returns a Config object with default values suitable for gen_default_config. This default values for List[Union] should be a list of each possible class of the union, to give a complete example that users can edit at their convenience. We solve the case of JointTextTask as an example. Other tasks will be solved in following diffs. Differential Revision: D13441705 fbshipit-source-id: bfa04de79d9dc2c491f740699c9e56c55e6b7fbc
Titousensei
force-pushed
the
export-D13441705
branch
from
0b41756 to
8faf643
Compare
Summary: Pull Request resolved: facebookresearch#211 because fblearner is confused about types List[Union], we can't give a default value to those Config parameters and we leave them empty. That's a problem for gen_default_config, which relies on instanciating components with default values. So those configs, like JointTextTask, can't be used with gen_default_config. This diff introduces a generic solution for Tasks like this (not for all components, coming soon) by allowing each task to provide an optional function "example_config" that returns a Config object with default values suitable for gen_default_config. This default values for List[Union] should be a list of each possible class of the union, to give a complete example that users can edit at their convenience. We solve the case of JointTextTask as an example. Other tasks will be solved in following diffs. Reviewed By: m3rlin45 Differential Revision: D13441705 fbshipit-source-id: d4d6a30341cff9b2e87db0342808c6933a37ad9c
Titousensei
force-pushed
the
export-D13441705
branch
from
8faf643 to
aa65493
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
because fblearner is confused about types List[Union], we can't
give a default value to those Config parameters and we leave them empty.
That's a problem for gen_default_config, which relies on instanciating
components with default values. So those configs, like JointTextTask, can't
be used with gen_default_config.
This diff introduces a generic solution for Tasks like this (not for all
components, coming soon) by allowing each task to provide an optional
function "example_config" that returns a Config object with default values
suitable for gen_default_config. This default values for List[Union] should
be a list of each possible class of the union, to give a complete example
that users can edit at their convenience.
We solve the case of JointTextTask as an example. Other tasks will be solved
in following diffs.
Differential Revision: D13441705