This repository was archived by the owner on Nov 22, 2022. It is now read-only.
gen_default_config dynamically loads custom components #196
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
Titousensei
force-pushed
the
export-D13604448
branch
from
58da674 to
f3ccf8c
Compare
Titousensei
added a commit
to Titousensei/pytext
that referenced
this pull request
Jan 9, 2019
…rch#196) Summary: Pull Request resolved: facebookresearch#196 Custom components are not import-ed in python main, gen_default_config can't find them. This diff dynamically loads the classes from the fully qualified class name. This is a fix for github issue facebookresearch#145 Differential Revision: D13604448 fbshipit-source-id: 12c31a72c81f3dbf12c097fd748a910c258535ae
…rch#196) Summary: Pull Request resolved: facebookresearch#196 Custom components are not import-ed in python main, gen_default_config can't find them. This diff dynamically loads the classes from the fully qualified class name. This is a fix for github issue facebookresearch#145 Reviewed By: hikushalhere Differential Revision: D13604448 fbshipit-source-id: c548f4f9a49c508ed3d258302c9eef1db9fbb688
Titousensei
force-pushed
the
export-D13604448
branch
from
f3ccf8c to
915558c
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Custom components are not import-ed in python main, gen_default_config
can't find them. This diff dynamically loads the classes from the fully
qualified class name.
This is a fix for github issue #145
Differential Revision: D13604448