Gets rid of all doc gen warnings for Python 3.7 #188
Conversation
This fixes the error that was preventing doc generation in Python 3.7. Note that doc generation will still throw a warning for 3.6, but a lot of time has been spent trying to fix that by Chris and me and moving ahead is the best approach anyway. Therefore, this commit also updates doc generation on CircleCI and ReadTheDocs to Python 3.7. Finally, enabling failures on warning for Sphinx doc gen so we lock this down for good.
facebook-github-bot
added
the
CLA Signed
There was a problem hiding this comment.
@snisarg has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
There was a problem hiding this comment.
@snisarg has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
|
@snisarg has updated the pull request. Re-import the pull request |
There was a problem hiding this comment.
@snisarg has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
|
@snisarg has updated the pull request. Re-import the pull request |
There was a problem hiding this comment.
@snisarg has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
|
@snisarg has updated the pull request. Re-import the pull request |
|
@snisarg has updated the pull request. Re-import the pull request |
There was a problem hiding this comment.
@snisarg has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
Motivation and Context
This fixes the error that was preventing doc generation in Python 3.7. Note that doc generation will still throw a warning for 3.6, but a lot of time has been spent trying to fix that by Chris and me and moving ahead is the best approach anyway. Therefore, this commit also updates doc generation on CircleCI and ReadTheDocs to Python 3.7. Finally, enabling failures on warning for Sphinx doc gen so we lock this down for good.
How Has This Been Tested
Tested by building docs locally without errors
Types of changes