This repository was archived by the owner on Nov 22, 2022. It is now read-only.
Cleanup Hogwild trainer #176
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary: Fix possible race conditions in Hogwild trainer. We join all the parallel processes after traning every epoch, and do evaulation after joining, so that we dont encounter races during evaluation and model selection. This implementation is similar to what sklearn is doing: https://github.com/srome/sklearn-hogwild/blob/master/hogwildsgd.py#L78 Differential Revision: D13426423 fbshipit-source-id: 8b021da032419cea5d872534fd28c98b8dfeb7f8
facebook-github-bot
added
the
CLA Signed
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Fix possible race conditions in Hogwild trainer.
We join all the parallel processes after traning every epoch, and do evaulation after joining, so that we dont encounter races during evaluation and model selection.
This implementation is similar to what sklearn is doing: https://github.com/srome/sklearn-hogwild/blob/master/hogwildsgd.py#L78
Differential Revision: D13426423