This repository was archived by the owner on Nov 22, 2022. It is now read-only.
Adding action_p to beam state in RNNG py #157
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
emilysw
force-pushed
the
export-D13366174
branch
from
7063717 to
52518a5
Compare
emilysw
pushed a commit
to emilysw/pytext
that referenced
this pull request
Jan 30, 2019
Summary: Pull Request resolved: facebookresearch#157 This diff stores action_p in ParserState. Previously, action_p was not updated to be saved for each state in the ParserState object, which may be useful in the future. Differential Revision: D13366174 fbshipit-source-id: fc9714d20e87299a577563cd7ccd7d4779635680
emilysw
force-pushed
the
export-D13366174
branch
from
52518a5 to
8fc0e4d
Compare
emilysw
pushed a commit
to emilysw/pytext
that referenced
this pull request
Jan 30, 2019
Summary: Pull Request resolved: facebookresearch#157 This diff stores action_p in ParserState. Previously, action_p was not updated to be saved for each state in the ParserState object, which may be useful in the future. Differential Revision: D13366174 fbshipit-source-id: 524e41c48d864a0a4b137d62c4936e0723f2c8a8
Summary: Pull Request resolved: facebookresearch#157 This diff stores action_p in ParserState. Previously, action_p was not updated to be saved for each state in the ParserState object, which may be useful in the future. Reviewed By: wowitsmrinal Differential Revision: D13366174 fbshipit-source-id: 1934b7cbb8ad96a64a13cabd758b731400135ee4
emilysw
force-pushed
the
export-D13366174
branch
from
8fc0e4d to
a5ad847
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary: This diff stores action_p in ParserState. Previously, action_p was not updated to be saved for each state in the ParserState object, which may be useful in the future.
Differential Revision: D13366174