This repository was archived by the owner on Nov 22, 2022. It is now read-only.
Model export doc #148
Closed
Model export doc #148
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since this follows immediately after the train tutorial using DocNN, many readers are confused about the outputs seen current on this page as they're expecting to use DocNN, not ATIS that's shown here. We're updating this tutorial to reflect DocNN instead. Although poor in results, the assumption is that someone running ATIS would be better equipped at this stage to understand the results of the test step than a beginner just trying out train and test with PyText.
facebook-github-bot
added
the
CLA Signed
There was a problem hiding this comment.
@snisarg has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
|
@snisarg has updated the pull request. Re-import the pull request |
There was a problem hiding this comment.
@snisarg has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and Context
The documentation for testing a model currently uses the ATIS tutorial. Most users, coming to this page after the DocNN tutorial are thrown off by the changes in the expected output.
This change should simplify this.
How Has This Been Tested
See the new resultant docs here: https://731-143080897-gh.circle-artifacts.com/0/docs/execute_your_first_model.html
Types of changes
Checklist