This repository was archived by the owner on Nov 22, 2022. It is now read-only.
fix clip_grad_norm_ if grad_norm > max_norm > 0: TypeError: '>' not supported between instances of 'float' and 'NoneType' #1054
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D17947540 |
…upported between instances of 'float' and 'NoneType' (facebookresearch#1054) Summary: Pull Request resolved: facebookresearch#1054 cast max_norm from None to 0.0 to fix the issue. Differential Revision: D17947540 fbshipit-source-id: a30141a01a11a3075561817537272dc568a1db19
chenyangyu1988
force-pushed
the
export-D17947540
branch
from
68be5c0 to
9151c04
Compare
|
This pull request was exported from Phabricator. Differential Revision: D17947540 |
|
This pull request has been merged in 41108ae. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary: cast max_norm from None to 0.0 to fix the issue.
Differential Revision: D17947540