This repository was archived by the owner on Nov 22, 2022. It is now read-only.
Provide row data even for packedLM #1031
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D17738252 |
Atry
pushed a commit
to Atry/pytext
that referenced
this pull request
Oct 3, 2019
Summary: Pull Request resolved: facebookresearch#1031 The reporter need the original text to generate the utterance column. See https://our.intern.facebook.com/intern/diffusion/FBS/browse/master/fbcode/pytext/metric_reporters/language_model_metric_reporter.py?lines=127 Reviewed By: borguz Differential Revision: D17738252 fbshipit-source-id: 8078d9f7cab39c2a692f2145f673638cb4745398
|
This pull request was exported from Phabricator. Differential Revision: D17738252 |
Atry
pushed a commit
to Atry/pytext
that referenced
this pull request
Oct 3, 2019
Summary: Pull Request resolved: facebookresearch#1031 The reporter need the original text to generate the utterance column. See https://our.intern.facebook.com/intern/diffusion/FBS/browse/master/fbcode/pytext/metric_reporters/language_model_metric_reporter.py?lines=127 Reviewed By: borguz Differential Revision: D17738252 fbshipit-source-id: 65ccd387473fd27cb9dd9d5f9e3c6d4f85463c30
|
This pull request was exported from Phabricator. Differential Revision: D17738252 |
Atry
pushed a commit
to Atry/pytext
that referenced
this pull request
Oct 3, 2019
Summary: Pull Request resolved: facebookresearch#1031 The reporter need the original text to generate the utterance column. See https://our.intern.facebook.com/intern/diffusion/FBS/browse/master/fbcode/pytext/metric_reporters/language_model_metric_reporter.py?lines=127 Reviewed By: borguz Differential Revision: D17738252 fbshipit-source-id: 46f548452085eded5f6a744dd2f1894d59b3ae79
|
This pull request was exported from Phabricator. Differential Revision: D17738252 |
Atry
pushed a commit
to Atry/pytext
that referenced
this pull request
Oct 4, 2019
Summary: Pull Request resolved: facebookresearch#1031 The reporter need the original text to generate the utterance column. See https://our.intern.facebook.com/intern/diffusion/FBS/browse/master/fbcode/pytext/metric_reporters/language_model_metric_reporter.py?lines=127 Reviewed By: borguz Differential Revision: D17738252 fbshipit-source-id: 143baa41ef80b174eab3007b8d4e21e2e8142cac
|
This pull request was exported from Phabricator. Differential Revision: D17738252 |
Summary: Pull Request resolved: facebookresearch#1031 The reporter need the original text to generate the utterance column. See https://our.intern.facebook.com/intern/diffusion/FBS/browse/master/fbcode/pytext/metric_reporters/language_model_metric_reporter.py?lines=127 Reviewed By: borguz Differential Revision: D17738252 fbshipit-source-id: 421f8b0df7ca48e86ef9f92d7c25483d89b48ff7
|
This pull request was exported from Phabricator. Differential Revision: D17738252 |
|
This pull request has been merged in 4d09e80. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary: The reporter need the original text to generate the utterance column. See
pytext/pytext/metric_reporters/language_model_metric_reporter.py
Lines 127 to 129 in 6d07f69
Differential Revision: D17738252