This repository was archived by the owner on Nov 22, 2022. It is now read-only.
(Easy) Rename FL trainers, remove 'NewDoc' from name #1005
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
kmalik22
pushed a commit
to kmalik22/pytext
that referenced
this pull request
Sep 26, 2019
…h#1005) Summary: Pull Request resolved: facebookresearch#1005 Follow up to D17370068, renamed: - FLNewDocSyncTrainer --> FLSyncTrainer - FLNewDocAsyncTrainer --> FLAsyncTrainer Also added config_adapter section for backwards compatibility of existing configs. Reviewed By: psuzhanhy Differential Revision: D17461127 fbshipit-source-id: 39c96a463c73939bf02239c208bf7133acac9b7a
kmalik22
force-pushed
the
export-D17461127
branch
from
82a061d to
0eb977b
Compare
kmalik22
pushed a commit
to kmalik22/pytext
that referenced
this pull request
Sep 26, 2019
…h#1005) Summary: Pull Request resolved: facebookresearch#1005 Follow up to D17370068, renamed: - FLNewDocSyncTrainer --> FLSyncTrainer - FLNewDocAsyncTrainer --> FLAsyncTrainer Also added config_adapter section for backwards compatibility of existing configs. Reviewed By: psuzhanhy Differential Revision: D17461127 fbshipit-source-id: 8ec4aa8bc6fe4588f39f8477c29aeeed729216e6
kmalik22
force-pushed
the
export-D17461127
branch
from
0eb977b to
88b4868
Compare
kmalik22
pushed a commit
to kmalik22/pytext
that referenced
this pull request
Sep 26, 2019
…h#1005) Summary: Pull Request resolved: facebookresearch#1005 Follow up to D17370068, renamed: - FLNewDocSyncTrainer --> FLSyncTrainer - FLNewDocAsyncTrainer --> FLAsyncTrainer Also added config_adapter section for backwards compatibility of existing configs. Reviewed By: psuzhanhy Differential Revision: D17461127 fbshipit-source-id: 76e9b3607bc465eb6c664c42cb7ee512a4b0fa1a
kmalik22
force-pushed
the
export-D17461127
branch
from
88b4868 to
01a70cc
Compare
kmalik22
pushed a commit
to kmalik22/pytext
that referenced
this pull request
Sep 26, 2019
…h#1005) Summary: Pull Request resolved: facebookresearch#1005 Follow up to D17370068, renamed: - FLNewDocSyncTrainer --> FLSyncTrainer - FLNewDocAsyncTrainer --> FLAsyncTrainer Also added config_adapter section for backwards compatibility of existing configs. Reviewed By: psuzhanhy Differential Revision: D17461127 fbshipit-source-id: a6d5dbd19b84e923ffd7e6f8b54af7af1d6dea03
kmalik22
force-pushed
the
export-D17461127
branch
from
01a70cc to
3897471
Compare
kmalik22
pushed a commit
to kmalik22/pytext
that referenced
this pull request
Sep 27, 2019
…h#1005) Summary: Pull Request resolved: facebookresearch#1005 Follow up to D17370068, renamed: - FLNewDocSyncTrainer --> FLSyncTrainer - FLNewDocAsyncTrainer --> FLAsyncTrainer Also added config_adapter section for backwards compatibility of existing configs. Reviewed By: psuzhanhy Differential Revision: D17461127 fbshipit-source-id: 83bd008102ebf88e58152d5a234d53a24a3db2ea
kmalik22
force-pushed
the
export-D17461127
branch
from
3897471 to
9e62b9a
Compare
kmalik22
pushed a commit
to kmalik22/pytext
that referenced
this pull request
Sep 27, 2019
…h#1005) Summary: Pull Request resolved: facebookresearch#1005 Follow up to D17370068, renamed: - FLNewDocSyncTrainer --> FLSyncTrainer - FLNewDocAsyncTrainer --> FLAsyncTrainer Also added config_adapter section for backwards compatibility of existing configs. Reviewed By: psuzhanhy Differential Revision: D17461127 fbshipit-source-id: 4c413036e92c9c0b3d86b4a175c9a7b086877374
kmalik22
force-pushed
the
export-D17461127
branch
from
9e62b9a to
ef8162a
Compare
kmalik22
pushed a commit
to kmalik22/pytext
that referenced
this pull request
Oct 1, 2019
…h#1005) Summary: Pull Request resolved: facebookresearch#1005 Follow up to D17370068, renamed: - FLNewDocSyncTrainer --> FLSyncTrainer - FLNewDocAsyncTrainer --> FLAsyncTrainer Also added config_adapter section for backwards compatibility of existing configs. Reviewed By: psuzhanhy Differential Revision: D17461127 fbshipit-source-id: ad9cc109a9b8169d32aee2b0ac17f38e757d51ec
kmalik22
force-pushed
the
export-D17461127
branch
from
ef8162a to
9f66922
Compare
…h#1005) Summary: Pull Request resolved: facebookresearch#1005 Follow up to D17370068, renamed: - FLNewDocSyncTrainer --> FLSyncTrainer - FLNewDocAsyncTrainer --> FLAsyncTrainer Also added config_adapter section for backwards compatibility of existing configs. Reviewed By: psuzhanhy Differential Revision: D17461127 fbshipit-source-id: d9004e711477a5d0875068daab72c0e940512593
kmalik22
force-pushed
the
export-D17461127
branch
from
9f66922 to
63eb104
Compare
|
This pull request has been merged in 6e3d6ff. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Follow up to D17370068, renamed:
Also added config_adapter section for backwards compatibility of existing configs.
Reviewed By: psuzhanhy
Differential Revision: D17461127