This repository was archived by the owner on Nov 22, 2022. It is now read-only.
assert trainer parameters #1004
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary: Pull Request resolved: facebookresearch#979 D17241503 selects only masked tokens for the final logits / targets during MLM. This fails when there are no masked tokens (e.g. at the end of a file there can be a very short batch). In this case, select just the first token in the first batch. BTW, the new masking strategy is faster (20%) than the old one - f138005051 vs f138005044. Differential Revision: D17370855 fbshipit-source-id: 6c8dbd6346e8f8db029047171cb81f147dc70a43
Summary: if early_stop_after is set, but do eval is false, early_stop_after is silently ignored. Add an assert to make users aware of bad config Reviewed By: hikushalhere Differential Revision: D17580419 fbshipit-source-id: b03d68a98eab0428a0295cca68d5fe377ddb8129
facebook-github-bot
added
the
CLA Signed
|
This pull request has been merged in 400c80b. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary: if early_stop_after is set, but do eval is false, early_stop_after is silently ignored. Add an assert to make users aware of bad config
Reviewed By: hikushalhere
Differential Revision: D17580419