Add Bean Machine VI to PPL Bench #125
Open
+57
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary: Adding VI support to PPL Bench so we can easily benchmark the performance of different configurations on the models there. To draw the samples that PPL Bench expects at the end, here we simply takes the VI distributions at the end of an inference (conditioned on the learned parameters) and draw N samples from them, where N equals number of iterations. Differential Revision: D40951663 fbshipit-source-id: 1a04fc658c027684811a58c7d5bdf158e231e6f6
facebook-github-bot
added
CLA Signed
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D40951663 |
| iterations: int, | ||
| num_warmup: int, | ||
| seed: int, | ||
| algorithm: str = "ADVI", |
feynmanliang
approved these changes
Nov 23, 2022
| .clone() | ||
| .detach() | ||
| ) | ||
| return MonteCarloSamples([samples]) |
Contributor
There was a problem hiding this comment.
Haha, this is fine but maybe we leave a TODO comment to prevent confusion
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Adding VI support to PPL Bench so we can easily benchmark the performance of different configurations on the models there.
To draw the samples that PPL Bench expects at the end, here we simply takes the VI distributions at the end of an inference (conditioned on the learned parameters) and draw N samples from them, where N equals number of iterations.
Differential Revision: D40951663