Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PARTNR version v0.1.0 #6

Merged
merged 12 commits into from
Jan 31, 2025
Merged

PARTNR version v0.1.0 #6

merged 12 commits into from
Jan 31, 2025

Conversation

aclegg3
Copy link
Contributor

@aclegg3 aclegg3 commented Jan 25, 2025 •
edited
Loading

Motivation and Context

This PR contains a set of updates from initial release to v0.1.0 including:

  • tutorials
  • improved documentation
  • bugfixes
  • and more...

How Has This Been Tested

CI (NOTE: expected to fail until habitat-sim v0.3.3 is released and built with conda)

Types of changes

  • Docs change / refactoring / dependency upgrade
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Meta Open Source bot. label Jan 25, 2025
@aclegg3 aclegg3 requested a review from akshararai January 25, 2025 04:27
akshararai
akshararai approved these changes Jan 27, 2025
View reviewed changes
Copy link

@akshararai akshararai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we might want to wait to hear from @xavierpuigf to confirm which VLM related files should go into the release versus not, but looks good otherwise. I didn't look at each code change carefully, because it was reviewed before.
Once merged, let's run the regression test that @zephirefaith did to confirm we get the same numbers.

akshararai
akshararai approved these changes Jan 30, 2025
View reviewed changes
Copy link

@akshararai akshararai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks great, thank you!

@aclegg3 aclegg3 merged commit 15e32e8 into main Jan 31, 2025
4 checks passed
@aclegg3 aclegg3 deleted the v0.1.0 branch January 31, 2025 00:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xavierpuigf xavierpuigf xavierpuigf left review comments

@akshararai akshararai akshararai approved these changes

Assignees
No one assigned
Labels
CLA Signed This label is managed by the Meta Open Source bot.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@aclegg3 @akshararai @xavierpuigf @facebook-github-bot