Fix computation with splited blocks #1434
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
|
Replaces #1432 |
teytaud
reviewed
Apr 22, 2022
| @@ -52,6 +52,7 @@ def _initialize(self) -> None: | |||
| self._dimension, self.block_dimension * self.num_blocks, replace=False | |||
| ).tolist() | |||
| indices.sort() # keep the indices sorted sorted so that blocks do not overlap | |||
| # Caution this is also important for split, so that splitted arrays end un in the same block | |||
There was a problem hiding this comment.
Suggested change
| # Caution this is also important for split, so that splitted arrays end un in the same block | |
| # Caution this is also important for split, so that splitted arrays end up in the same block |
teytaud
reviewed
Apr 22, 2022
| data = self._transform(recommendations[0].args[0]) | ||
| assert not recommendations[0].kwargs | ||
| # we can concatenate since blocks are necessarily sorted | ||
| data = np.concatenate(recommendations[0].args, axis=0) |
There was a problem hiding this comment.
Aaaaaaah c'etait ca. Ok My bad I was testing "flatten" and desperately failing.
teytaud
approved these changes
Apr 22, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Types of changes
Motivation and Context / Related issue
How Has This Been Tested (if it applies)
Checklist