Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add fishing experiment #1394

Merged
merged 6 commits into from
Mar 21, 2022
Merged

Add fishing experiment #1394

merged 6 commits into from
Mar 21, 2022

Conversation

teytaud
Copy link
Contributor

@teytaud teytaud commented Mar 17, 2022

Types of changes

  • Docs change / refactoring / dependency upgrade
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Motivation and Context / Related issue

We had the code but not the xp in experiments.py :-(

How Has This Been Tested (if it applies)

Checklist

  • The documentation is up-to-date with the changes I made.
  • I have read the CONTRIBUTING document and completed the CLA (see CLA).
  • All tests passed, and additional code has been covered with new tests.

@facebook-github-bot facebook-github-bot added the CLA Signed Do not delete this pull request or issue due to inactivity. label Mar 17, 2022
@jrapin jrapin changed the title Fishing experiment Add fishing experiment Mar 21, 2022
@teytaud teytaud merged commit d988f2d into main Mar 21, 2022
@teytaud teytaud deleted the fishing_xp branch March 21, 2022 15:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jrapin jrapin jrapin approved these changes

Assignees
No one assigned
Labels
CLA Signed Do not delete this pull request or issue due to inactivity.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@teytaud @jrapin @facebook-github-bot