Fix TORCH_CUDA_ARCH_LIST override for Windows #294
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
|
@jeongseok-meta has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
|
@jeongseok-meta merged this pull request in ecbc857. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Second attempt to fix pymomentum build with CUDA support from #293. This involves switching from overriding
TORCH_CUDA_ARCH_LISTusing CMake options (which resulted in a syntax error for Windows) to setting it as an environment variable, and updating the CUDA version to the latest on CI (previously, 12.6.3 failed to be set up in CMake, resulting in a failed test program build).Checklist:
pixi run lintTest Plan
CI