-
-
Notifications
You must be signed in to change notification settings - Fork 634
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Relative recursive defaults take3 #1170
Conversation
This pull request introduces 1 alert when merging bfecf9f into 143d060 - view on LGTM.com new alerts:
|
This pull request introduces 1 alert when merging bde870c into 143d060 - view on LGTM.com new alerts:
|
bde870c
to
8a24c63
Compare
This pull request fixes 1 alert when merging c5bc56a into c1eb243 - view on LGTM.com fixed alerts:
|
This pull request fixes 1 alert when merging 5700988 into c1eb243 - view on LGTM.com fixed alerts:
|
5700988
to
d8b840c
Compare
This pull request fixes 1 alert when merging d8b840c into c1eb243 - view on LGTM.com fixed alerts:
|
This pull request fixes 1 alert when merging 83eaebb into c1eb243 - view on LGTM.com fixed alerts:
|
This pull request fixes 1 alert when merging 5388f5f into 96d232d - view on LGTM.com fixed alerts:
|
5388f5f
to
6d43679
Compare
This pull request introduces 4 alerts when merging 6d43679 into 522431d - view on LGTM.com new alerts:
|
This pull request introduces 4 alerts when merging 62ad0a5 into b2d5310 - view on LGTM.com new alerts:
|
This pull request introduces 4 alerts when merging 3e802dc into b2d5310 - view on LGTM.com new alerts:
|
3e802dc
to
fa0c7aa
Compare
This pull request introduces 1 alert when merging fa0c7aa into 9122b03 - view on LGTM.com new alerts:
|
fa0c7aa
to
b27e6c9
Compare
This pull request introduces 1 alert when merging b27e6c9 into 9122b03 - view on LGTM.com new alerts:
|
This pull request introduces 1 alert when merging e04ce9c into 9122b03 - view on LGTM.com new alerts:
|
e04ce9c
to
97e5c83
Compare
This pull request introduces 1 alert when merging 97e5c83 into 9122b03 - view on LGTM.com new alerts:
|
97e5c83
to
0da4dd3
Compare
This pull request introduces 2 alerts when merging 0da4dd3 into 9122b03 - view on LGTM.com new alerts:
|
0da4dd3
to
30a057f
Compare
This pull request introduces 2 alerts when merging 30a057f into 9122b03 - view on LGTM.com new alerts:
|
30a057f
to
a7318cf
Compare
This pull request introduces 2 alerts when merging a7318cf into 79127d5 - view on LGTM.com new alerts:
|
a7318cf
to
245f731
Compare
7ccd023
to
43da2b8
Compare
04f1b7d
to
b6a6ef1
Compare
2bda47d
to
2f7e3b1
Compare
- Defaults List - Packages - Extending configs - Configuring experiments
2f7e3b1
to
cbd055f
Compare
Design document here
This is a from-scratch implementation.
The biggest change in requirements is that we are now aiming to support relocating sub-trees with packages overrides, which means both config groups and package overrides are relative.
In terms of implementation, this version goes through an intermediate tree that is being converted to a list with a DFS walk.
This simplifies the implementation and will also be great for visualization purposes.
Closes #171 (reimplements)
Closes #326 (reimplements)
Closes #1080 (reimplements)
Closes #1102
Closes #956
Closes #1107
Closes #354
Followup tasks:
_self_
trailing by default)._group_
and_name_
in package header.To-do list
_global_
_global_.foo
_name_
Decision: package header will remain absolute.
Decision: package will not be deprecated for now
(with the exception of self that can be after them)