Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Override grammar: allow question marks in unquoted strings #1597

Closed
odelalleau opened this issue May 3, 2021 · 0 comments · Fixed by #1598
Closed

Override grammar: allow question marks in unquoted strings #1597

odelalleau opened this issue May 3, 2021 · 0 comments · Fixed by #1598
Labels
enhancement Enhanvement request

Comments

@odelalleau
Copy link
Collaborator

odelalleau commented May 3, 2021 •
edited
Loading

🚀 Feature Request

Question marks should be allowed in unquoted strings so as to match OmegaConf's grammar (see the corresponding PR in OmegaConf: omry/omegaconf#638)

Edit: I am working on it
@odelalleau odelalleau added the enhancement Enhanvement request label May 3, 2021
odelalleau added a commit to odelalleau/hydra that referenced this issue May 3, 2021
@odelalleau
Override grammar: allow question marks in unquoted strings
837227a 
Fixes facebookresearch#1597
@odelalleau odelalleau mentioned this issue May 3, 2021
Merged
odelalleau added a commit to odelalleau/hydra that referenced this issue May 3, 2021
@odelalleau
Override grammar: allow question marks in unquoted strings
044ced2 
Fixes facebookresearch#1597
odelalleau added a commit to odelalleau/hydra that referenced this issue May 3, 2021
@odelalleau
Override grammar: allow question marks in unquoted strings
65d2847 
Fixes facebookresearch#1597
odelalleau added a commit that referenced this issue May 4, 2021
@odelalleau
Override grammar: allow question marks in unquoted strings (#1598)
713d5ea 
Override grammar: allow question marks in unquoted strings

Fixes #1597
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement Enhanvement request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Override grammar: allow question marks in unquoted strings odelalleau/hydra
1 participant
@odelalleau