[gala kinematic] split train and test stages #1751
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
vincentpierre
changed the title
| @@ -369,7 +369,7 @@ EpisodeSet generateBenchmarkEpisodeSet(const EpisodeGeneratorConfig& config, | |||
|
|
|||
| // distribute stages across episodes | |||
| for (int i = 0; i < numEpisodes; i++) { | |||
| int stageIndex = i * config.numStageVariations / numEpisodes; | |||
| int stageIndex = i * (config.maxStageNumber - config.minStageNumber) / numEpisodes; | |||
| int numStageVariations = 12; // see selectedReplicaCadBakedStages | ||
| // int numStageVariations = 12; // see selectedReplicaCadBakedStages | ||
| int minStageNumber = 0; | ||
| int maxStageNumber = 12; |
There was a problem hiding this comment.
off-by-one here? previously, the max stage index was 11, because there are only 12 stages.
| @@ -13,7 +13,9 @@ namespace batched_sim { | |||
| struct EpisodeGeneratorConfig { | |||
| int numEpisodes = 100; | |||
| int seed = 3; // this is 3 for legacy reason | |||
| int numStageVariations = 12; // see selectedReplicaCadBakedStages | |||
| // int numStageVariations = 12; // see selectedReplicaCadBakedStages | |||
| int minStageNumber = 0; | |||
There was a problem hiding this comment.
"index" is probably a better term than "number"
Skylion007
approved these changes
May 18, 2022
| .def_readwrite("num_stage_variations", &EpisodeGeneratorConfig::numStageVariations, R"(Todo)") | ||
| // .def_readwrite("num_stage_variations", &EpisodeGeneratorConfig::numStageVariations, R"(Todo)") | ||
| .def_readwrite("min_stage_number", &EpisodeGeneratorConfig::minStageNumber, R"(Todo)") | ||
| .def_readwrite("max_stage_number", &EpisodeGeneratorConfig::maxStageNumber, R"(Todo)") |
There was a problem hiding this comment.
FYI, the docstring is optional...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and Context
How Has This Been Tested
Types of changes
Checklist